Tissevert/pandoc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

data/pandoc.lua: fix deletion of nonexistent attributes

Browse source 
Fixes: #5569
This commit is contained in:
Albert Krewinkel 2019-06-11 19:39:42 +02:00
parent 03b9f3d5f3
commit 7f9b32e36a
No known key found for this signature in database
GPG key ID: 388DC0B21F631124
2 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
data/pandoc.lua
View file

@ -846,7 +846,10 @@ local AttributeList = {
__newindex = function (t, k, v) __newindex = function (t, k, v)
local cur, idx = List.find_if(t, assoc_key_equals(k)) local cur, idx = List.find_if(t, assoc_key_equals(k))
if v == nil then if v == nil and not cur then
-- deleted key does not exists in list
return
elseif v == nil then
table.remove(t, idx) table.remove(t, idx)
elseif cur then elseif cur then
cur[2] = v cur[2] = v

6
test/lua/module/pandoc.lua
View file

@ -62,6 +62,12 @@ return {
local assoc_list = setmetatable(attributes, nil) local assoc_list = setmetatable(attributes, nil)
assert.are_same(assoc_list, {{'b', '2'}}) assert.are_same(assoc_list, {{'b', '2'}})
end), end),
test('remains unchanged if deleted key did not exist', function ()
local assoc_list = pandoc.List:new {{'alpha', 'x'}, {'beta', 'y'}}
local attributes = pandoc.Attr('', {}, assoc_list:clone()).attributes
attributes.a = nil
assert.are_same(pandoc.List:new(attributes), assoc_list)
end),
test('gives key-value pairs when iterated-over', function () test('gives key-value pairs when iterated-over', function ()
local attributes = {width = '11', height = '22', name = 'test'} local attributes = {width = '11', height = '22', name = 'test'}
local attr = pandoc.Attr('', {}, attributes) local attr = pandoc.Attr('', {}, attributes)